Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Feast Operator component #1498

Merged
merged 2 commits into from
Jan 31, 2025
Merged

feat: Add Feast Operator component #1498

merged 2 commits into from
Jan 31, 2025

Conversation

redhatHameed
Copy link
Contributor

@redhatHameed redhatHameed commented Jan 14, 2025 •
edited
Loading

Description

Adding Feast Operator component for Feast Feasture Store -> https://github.com/opendatahub-io/feast/tree/stable/infra/feast-operator

Jira : https://issues.redhat.com/browse/RHOAIENG-14792
https://issues.redhat.com/browse/RHOAIENG-19100

How Has This Been Tested?

added Feast component as a Managed in dsc CR

    feastoperator:
      managementState: Managed

status reflect with Ready

    - lastHeartbeatTime: '2025-01-14T15:08:15Z'
      lastTransitionTime: '2025-01-13T19:30:59Z'
      message: 1/1 deployments ready
      reason: Ready
      status: 'True'
      type: FeastOperatorReady

Operator logs

{"level":"info","ts":"2025-01-13T19:27:22Z","msg":"Starting Controller","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator"}


{"level":"info","ts":"2025-01-13T19:27:24Z","msg":"Starting workers","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","worker count":1}


"level":"info","ts":"2025-01-13T19:30:33Z","msg":"reconcile","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"apply","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"Executing action","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb","action":"github.com/opendatahub-io/opendatahub-operator/v2/controllers/components/feastoperator.initialize"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"Executing action","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb","action":"github.com/opendatahub-io/opendatahub-operator/v2/controllers/components/feastoperator.devFlags"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"Executing action","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb","action":"github.com/opendatahub-io/opendatahub-operator/v2/pkg/controller/actions/render/kustomize.(*Action).run-fm"}

Feast installation successful as shown in below screen

Screenshot or short clip

Screenshot 2025-01-14 at 10 16 28 AM

Merge criteria

  • You have read the contributors guide.
  • [x ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • [ x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • [ x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ x] The developer has manually tested the changes and verified that the changes work

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 135 lines in your changes missing coverage. Please review.

Project coverage is 19.96%. Comparing base (ecdb2dc) to head (d15be4d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...trollers/components/feastoperator/feastoperator.go 0.00% 65 Missing ⚠️
...mponents/feastoperator/feastoperator_controller.go 0.00% 38 Missing ⚠️
.../feastoperator/feastoperator_controller_actions.go 0.00% 22 Missing ⚠️
.../components/feastoperator/feastoperator_support.go 0.00% 6 Missing ⚠️
pkg/upgrade/upgrade.go 0.00% 3 Missing ⚠️
...atasciencecluster/datasciencecluster_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
- Coverage   20.21%   19.96%   -0.25%     
==========================================
  Files         158      162       +4     
  Lines       10829    10964     +135     
==========================================
  Hits         2189     2189              
- Misses       8406     8541     +135     
  Partials      234      234

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redhatHameed
Copy link
Contributor Author

/test all

tchughesiv
tchughesiv suggested changes Jan 14, 2025
View reviewed changes
get_all_manifests.sh Outdated Show resolved Hide resolved
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from 9e2280a to d1251e2 Compare January 23, 2025 18:53
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from d1251e2 to cb9f77f Compare January 23, 2025 19:06
@redhatHameed redhatHameed marked this pull request as ready for review January 23, 2025 19:15
@redhatHameed redhatHameed marked this pull request as draft January 24, 2025 13:36
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from cb9f77f to 7dfbb31 Compare January 24, 2025 18:58
tchughesiv
tchughesiv reviewed Jan 24, 2025
View reviewed changes
get_all_manifests.sh Outdated Show resolved Hide resolved
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from 7dfbb31 to 0ddcf21 Compare January 24, 2025 19:02
@redhatHameed redhatHameed marked this pull request as ready for review January 24, 2025 19:02
@openshift-ci openshift-ci bot requested a review from Sara4994 January 24, 2025 19:02
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from 0ddcf21 to e2ddf09 Compare January 24, 2025 19:15
@redhatHameed
Copy link
Contributor Author

@ykaliuta / @zdtsw / @MarianMacik / @ykaliuta Could you please review this PR when you get chance, or can ask if it needs to be reviewed by any other folks. thanks!

@redhatHameed redhatHameed force-pushed the featurestore-incubation branch 2 times, most recently from 1b9458d to 991b94a Compare January 28, 2025 15:37
@redhatHameed
Copy link
Contributor Author

adding @opendatahub-io/feature-store-maintainers and @opendatahub-io/platform for review Thanks

@zdtsw zdtsw removed the request for review from Sara4994 January 30, 2025 17:28
@ykaliuta
Copy link
Contributor

Thanks to the framework, pretty straight forward, just couple of questions.

@ykaliuta
Copy link
Contributor

Should it really be called "operator"? Isn't it just "feast" feature in the DataScienceCluster?

@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from 991b94a to d15be4d Compare January 31, 2025 15:52
@redhatHameed
Copy link
Contributor Author

Thanks to the framework, pretty straight forward, just couple of questions.

agree and thanks for this deatils doc

@redhatHameed
Copy link
Contributor Author

Should it really be called "operator"? Isn't it just "feast" feature in the DataScienceCluster?

hope that has been answered with offline discussion on slack thread for record I have added description on FeastOperatorComponentName field/constant //"feastoperator" is named to distinguish it from "feast," as it specifically refers to the operator responsible for deploying, managing, Feast feature store services and to avoid confusion with the core Feast components.

@openshift-ci openshift-ci bot added the lgtm label Jan 31, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 89b607a into opendatahub-io:main Jan 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw left review comments

@ykaliuta ykaliuta ykaliuta approved these changes

@MarianMacik MarianMacik Awaiting requested review from MarianMacik

@tchughesiv tchughesiv Awaiting requested review from tchughesiv

Assignees

@ykaliuta ykaliuta

@tchughesiv tchughesiv

Labels
approved component/feast lgtm
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@redhatHameed @ykaliuta @zdtsw @tchughesiv @openshift-merge-robot